search

sgkit-dev / bio2zarr

Convert bioinformatics file formats to Zarr
Apache License 2.0
28 stars 7 forks source link

Make chunks have the same number of dimensions as shape #269

Closed tomwhite closed 4 months ago

tomwhite commented 4 months ago

I noticed this when working on #254 - Zarr v3 requires that shape and chunks both have the same number of dimensions. Zarr v2 doesn't, but there's no harm in setting the missing dimensions to a single chunk, and it's arguably clearer.

coveralls commented 4 months ago

Coverage Status

coverage: 98.854% (-0.04%) from 98.895% when pulling ada71fa4a1acdd62a9de3a29adab29cc0357399e on tomwhite:chunk-ndim into 69ee0e82c03933ff06369764610168a4c8694642 on sgkit-dev:main.