search

sgkit-dev / sgkit

Scalable genetics toolkit
https://sgkit-dev.github.io/sgkit
Apache License 2.0
217 stars 32 forks source link

Avoid disabling jit on guvectorised functions #1199

Closed timothymillar closed 3 months ago

timothymillar commented 4 months ago

Leaving NUMBA_DISABLE_JIT=1 for test_pedigree.py which contains many jitted functions.

timothymillar commented 4 months ago

Hmm, not sure what to do about coverage here

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (6b10a77) to head (e315f52).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1199 +/- ## ========================================== Coverage 100.00% 100.00% ========================================== Files 52 52 Lines 5204 4353 -851 ========================================== - Hits 5204 4353 -851 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

timothymillar commented 3 months ago

This still runs tests with the jit disabled for two files:

Both of these files have lots njit functions without guvectorize. This is a bit fragile so we'll see if it sticks around.

I also looked into using pytest to mark certain tests for running with the jit disabled. This doesn't work because the guvectorize functions are compiled at import time which happens even if the tests are deselected.