search

sgkit-dev / sgkit

Scalable genetics toolkit
https://sgkit-dev.github.io/sgkit
Apache License 2.0
217 stars 32 forks source link

Fix xarray repr in doctests #1205

Closed tomwhite closed 4 months ago

tomwhite commented 4 months ago
tomwhite commented 4 months ago

The latest Xarray doesn't support Python 3.8, so it has the old repr. Is it possible to disable doctests for Python 3.8?

jeromekelleher commented 4 months ago

LGTM. I'd be perfectly happy just doing doctests on one Python version. Do we need to pin to the new xarray for CI?

tomwhite commented 4 months ago

I'd be perfectly happy just doing doctests on one Python version.

I can't see any easy way to do that.

Perhaps we can drop Python 3.8: https://scientific-python.org/specs/spec-0000/#support-window