search

sgkit-dev / vcztools

Partial reimplementation of bcftools for VCF Zarr
Apache License 2.0
3 stars 3 forks source link

Remove numba #35

Closed tomwhite closed 3 months ago

tomwhite commented 3 months ago

Fixes #33

tomwhite commented 3 months ago

This is failing because the C implementation is writing all INFO and FORMAT fields that it finds in the Zarr store, not just the ones that are in the supplied VCF header - see the test_write_vcf__set_header test.

I'm not sure what behaviour we want here @jeromekelleher?

jeromekelleher commented 3 months ago

I think we want to remove the idea of writing from a full stored header, so I'd just disable/remove this test for now. Parsing the header to determine what fields to write seems the wrong way around to me.

tomwhite commented 3 months ago

Sounds good. I've skipped the test now.