search

sglanzer-deprecated / ember-cli-blanket

Blanket based code coverage for ember-cli projects
MIT License
110 stars 46 forks source link

ember-cli-blanket does not work with ember-cli-qunit 2.2.2 or newer. #162

Open nathanhammond opened 8 years ago

nathanhammond commented 8 years ago

The fix here is for ember-cli-blanket to hook ember-cli-test-loader to insert its module instrumentation. That's the ideal insertion point for what you're trying to accomplish. This also has the benefit of reducing the number of intimate and private APIs inside of Ember's module loading infrastructure that it needs to touch. Also it no longer has to support autostart as a feature since modules will be instrumented as part of the same loading step that Ember normally uses.

Reference: https://github.com/ember-cli/ember-cli-qunit/issues/147

RobbieTheWagner commented 8 years ago

👍 definitely broken for all my addons that I have updated 😞

sglanzer-deprecated commented 8 years ago

I'd love to find time to fix this, but most of my effort on code coverage has been dedicated to ember-cli-code-coverage these days. I'm more than happy to accept a PR, but I doubt I'll have time to fix this for at least a week or two.

luketheobscure commented 8 years ago

@sglanzer should we start migrating our projects over to ember-cli-code-coverage then?

sglanzer-deprecated commented 8 years ago

@luketheobscure Yeah, with the 0.3 release ember-cli-code-coverage supports addons, so I would encourage a swap. I haven't marked this repo as deprecated yet, but that's probably the next step. I don't think @jschilli or I have any time to actively work on maintaining this and I believe ember-cli-code-coverage is the way forward

sglanzer-deprecated commented 8 years ago

@jschilli @rwjblue @kategengler any thoughts on endorsing a cutover?

luketheobscure commented 8 years ago

@sglanzer It would still be helpful to get this fixed. I can't switch over to ember-cli-code-coverage until they get it playing nicely with CoffeeScript (https://github.com/kategengler/ember-cli-code-coverage/issues/55).

RobbieTheWagner commented 8 years ago

@luketheobscure I think we ought to have everyone focus on ember-cli-code-coverage, rather than putting time into trying to get this working again.

sglanzer-deprecated commented 8 years ago

@luketheobscure I have to agree with @rwwagner90 - unfortunately the time available to dedicate to this type of project is severely limited, so we need to throw any effort behind a blessed implementation

I'm also more than happy to accept a PR and publish a new release if you find that to be a shorter path for resolving your situation

RobbieTheWagner commented 7 years ago

Should we close this issue, since ember-cli-code-coverage is the new thing to use?

sglanzer-deprecated commented 7 years ago

Yeah, I'd be in favor of archiving the project as a whole

On Aug 31, 2017 9:22 AM, "Robert Wagner" notifications@github.com wrote:

Should we close this issue, since ember-cli-code-coverage is the new thing to use?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sglanzer/ember-cli-blanket/issues/162#issuecomment-326293511, or mute the thread https://github.com/notifications/unsubscribe-auth/AIm6ljxvQZ9Y42Sr6oOFia6LR3vU2CDMks5sdrOSgaJpZM4J8aew .

RobbieTheWagner commented 7 years ago

@sglanzer deprecating does sound like a good idea. I was just looking through open issues that are lingering in my GitHub and wanted to see what you thought.