search

sglyon / MINPACK.jl

Wrapper for cminpack multivariate root finding routines
Other
17 stars 4 forks source link

Passing tests with incorrect results #4

Open fatteneder opened 4 years ago

fatteneder commented 4 years ago

i had a look into the test cases used in this package and realized that the tests only check for converged = true. printing out the actual zeros x and function values f reveals that some results disagree with what is in the literature, e.g. https://dl.acm.org/doi/pdf/10.1145/355934.355936 (if think that's the original article that was used for the development of minpack, also cited in https://github.com/devernay/cminpack/tree/master/examples).

i have not checked if this is a bug in MINPACK.jl or in CMINPACK itself.

thinking about better bests, my first proposal would be to test against the same tests CMINPACK uses.

sglyon commented 4 years ago

Thanks for pointing this out. I believe this test suite is a julia implementation of the tests from minpack.

The uncertainty about their origin is that I didn't write them, but borrowed them from another package I maintain: https://github.com/JuliaNLSolvers/NLsolve.jl/blob/master/test/minpack.jl

I don't have time to work on this myself, but would be happy to accept any PR that addresses this issue