search

sglyon / ORCA.jl

Julia interface to Plotly's ORCA image exporter app
3 stars 5 forks source link

Fix orca_cmd not escaping properly in paths.jl #22

Closed EHBaozi closed 4 years ago

EHBaozi commented 4 years ago

This fixes #21. I believe it should not affect behavior on Unix-like systems but do kindly test to verify (I tested in WSL).

codecov-io commented 4 years ago

Codecov Report

Merging #22 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff          @@
##           master   #22   +/-   ##
====================================
  Coverage      92%   92%           
====================================
  Files           1     1           
  Lines          25    25           
====================================
  Hits           23    23           
  Misses          2     2

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 23c2292...4c646bc. Read the comment docs.

sglyon commented 4 years ago

Thank you!

daschw commented 4 years ago

It would be great to have a release with this.