search

sgminer-dev / sgminer

Scrypt GPU miner
GNU General Public License v3.0
629 stars 825 forks source link

Seemingly improper DIFF display (WAS: Network DIFF on Feathercoin) #16

Closed NNygren closed 10 years ago

NNygren commented 10 years ago

Being reported incorrectly on Feathercoin network. For instance, at the time of writing: cgminer shows 222 sgminer shows 14.6M

veox commented 10 years ago

This is not Feathercoin-specific.

I have reverted the display style to that of cgminer 3.1.1. That is, if we display share difficulty as integers (1, 2, 4, ...), and not their real network-wide value (0.000015, 0.00003, 0.00006, ...), then it only makes sense to display and count in the same manner throughout the entire interface.

See same question on reddit

Related commit: https://github.com/veox/sgminer/commit/cb806d24373cd0f4526da71299ef693f45fcd51e

Note that it was displayed like this since forever, and only started showing "true netdiff" since the commit that the commit above fixes. This was due to cgminer discontinuing scrypt support.

I will leave this issue open for a while if someone thinks this warrants a discussion.

NNygren commented 10 years ago

It's not important to me as the software works just fine for the intended purpose. Although having been used to cgminer 3.7.2's display; I admit that I, in my limited understanding, fail to see the advantage to reverting the display style. Yet, all I really want is to hash. Cheers :)

veox commented 10 years ago

IMO true network-style difficulty display is better, too, but it involves slightly more changes, and would generate a lot more "difficulty is wrong" reports.

Steve-15 commented 10 years ago

I understand what you are saying about using consistent units in the interface. What about consistent units across applications? All of the coin daemons (e.g. litcoind, dogecoind, etc...) use the "old" cgminer 3.7 way.

veox commented 10 years ago

@phred02, see https://github.com/veox/sgminer/issues/115

This is low on my personal priority list.

devzer01 commented 10 years ago

Hi veox, thanks for your contribution to keep the gpu miner community active with sgminer, i also came here wondering about the network difficulty but after reading your comment it makes more sense to me now. Because i always wondered what 64/128/256 means when i get difficulty assigned from the pool.

So if i understand correctly. with the way sgminer is displaying network difficulty now we can easily see when we solve a block or comes close to solving a block because the result in our share will match network difficulty thats showed in sgminer, am i right?

Thanks for your time reading this.

veox commented 10 years ago

@devzer01 yes, exactly. That is the main purpose of keeping the units consistent.