search

sgminer-dev / sgminer

Scrypt GPU miner
GNU General Public License v3.0
631 stars 825 forks source link

Warnings when compiling with VC++ 2010 #186

Closed Bllacky closed 10 years ago

Bllacky commented 10 years ago

When compiling with VC ++ I get a huge list of warnings. I will attach it to this message, maybe you will find something interesting in it.

http://www.mediafire.com/view/9i5p6a7zmrbd1du/Output-Build.txt

If I have time or someone else has time I will begin work on these warnings. But mind you, last time when I have written C++ code was 10 years ago.

Bllacky commented 10 years ago

Update I have moved to Visual C++ 2012. It seems there is no problem to compile with this version of Visual C++. However the warning are still there. I think these warnings are specific for compiling in x64.

Edit: No, they are not related to compiling in x64, but I found a way to fix some of them. for instance:

instead of

int len, quota, qlen; you can write

decltype (strlen(arg)) len, quota, qlen;

This fixes the conversion warnings for all 3 variables. However, I do not know if this will work with gcc .

I can try and make a full fixed version just of sgminer.c and see if that flies with Linux.

Bllacky commented 10 years ago

After managing to fix about 5 warnings, I have concluded that I can fix at least a few of them. However, I am not sure if this will affect compiling on other platforms.

I need someone to test it.

mrbrdo commented 10 years ago

I assume this is obsolete now.