sgminer-dev / sgminer

Scrypt GPU miner
GNU General Public License v3.0
631 stars 825 forks source link

Feature: Pool Grouping #242

Open mfiano opened 10 years ago

mfiano commented 10 years ago

I propose a feature addition, "pool groups". It would be nice to group pools into sections, which would be very useful, particularly for Betarigs, and other rig rental services.

If for instance, I have 3 pools defined, each for Betarigs, then when one becomes rented out, it will become active and switch to it. However, to prevent rentals on the other 2, we would need to set them as disabled. This functionality does not exist in Betarigs, MiningRigRentals, etc, so it is up to the miner to add it. It is required these days to have more than 1 rental rig per actual rig, as different pool settings for each algorithm exist.

So with a pool group, and all the Betrigs pools defined within it, we could add pool group actions, such as disable-unused: true, to disable the other 2 when one becomes active. This could come in handy for other uses I'm sure, and should be fairly trivial to add. Let me know what you think :)

mfiano commented 10 years ago

This works because Betarigs, MiningRigRentals, and maybe others detect when a rig is not polling for data and prevents users from renting them out. If sgminer is not running, you cannot rent out that rig.

bullus77 commented 10 years ago

I use the same rig for x11 and x13, if I enabled them both at betarigs and x11 is rented out, will the x13 automatic be offline?

mfiano commented 10 years ago

No, that's why we need this feature.

bullus77 commented 10 years ago

Ok, but did u ask at betarigs or miningrigrentals if they can add that feature? I think it's easier that they set it to disable if the other algo is rented?

mfiano commented 10 years ago

I have asked countless times without a reply. None of the services do this anyway. It would be nice to do it client-side in case new services pop up in the future. All it would take is to be able to group pools and apply different options to groups.

bullus77 commented 10 years ago

Ok, I'm in.

platinum4 commented 10 years ago

@mfiano didn't @ystarnaud take care of this with his configuration parser, as we saw in IRC chat about 2 weeks ago? Is this issue closable?

mfiano commented 10 years ago

The configuration parser just allows for splitting of configuration options. There is no conditional logic involved there, as is needed here.

platinum4 commented 9 years ago

@ystarnaud didn't you already solve this for axion a while back?