search

sgminer-dev / sgminer

Scrypt GPU miner
GNU General Public License v3.0
631 stars 825 forks source link

Config generated by sgminer is invalid #50

Open Project-Khepri opened 10 years ago

Project-Khepri commented 10 years ago

If you make changes to the intensities from a running instance of sgminer and you hit [W]rite, it writes the config without problems but upon reload it gives an error because it writes 0 value to the other unused intensities.

Also it doesn't write "gpu-threads" inside the config file

gacheson commented 10 years ago

I'm looking into implementing a better way to handle zero values without sgminer throwing an error for what is a relatively harmless issue. Currently, that particular error is handled well enough as sgminer "skips over" invalid values when reading from the configuration file. The error message is what's left behind.

veox commented 10 years ago

Commit that introduced writing xintensity and rawintensity to config: https://github.com/veox/sgminer/commit/de08e71ea271fd84eba6fd40a2c998c22a138b18

cyber-punk commented 10 years ago

There are problems with the new intensities and the config, writing to config and trying to start sgminer again fails due to other intensities having 0 values. Why not check which intensity is used and only write that value. Also the config is not writing any of the video card settings to the config, they all get written with 0 values.

veox commented 10 years ago

Pushed b5b20c19f6c70391d357c5b477120d2e7cab2d26 and 8043af5ec704c859a231e06e6fd62c395aa8cd03 - band-aids at best.

@cyber-punk cannot reproduce.

Pushing issue away to milestone 4.2.0.

veox commented 10 years ago

poolname and state are not written, too.

Essentially, have to go through the git log and add everything in manually to write_config().

Ideally, configuration options should be stored in a struct (or something) and iterated over.

platinum4 commented 10 years ago

@Project-Khepri @veox is this now a non-issue as of https://github.com/sgminer-dev/sgminer/pull/277 ?

If so, is this issue moot and closable?