search

sgnl05 / sgnl05-sssd

Puppet module for SSSD
https://forge.puppet.com/sgnl05/sssd
GNU General Public License v3.0
17 stars 76 forks source link

Mkhomedir issue on CentOS 8 #104

Closed ybrock closed 4 years ago

ybrock commented 4 years ago

Hi,

I've found an issue with CentOS 8. At line 299 of init.pp, you have to use another fact than $::facts['os']['name'] == 'Redhat' to make it work on CentOS 8 :

case $::osfamily {

'RedHat': {
if ($::facts['os']['name'] == 'Fedora' and versioncmp($::facts['os']['release']['major'], '28') >= 0) or ( $::facts['os']['name'] == 'Redhat' and versioncmp($::facts['os']['release']['major'], '8') >= 0) {

Something like : ( $::facts['os']['family'] == 'Redhat' and versioncmp($::facts['os']['release']['major'], '8') >= 0) {

What do you think ? Should I submit a pull request, or somebody wants to fix it ?

Cheers Yvan

ghoneycutt commented 4 years ago

Hi @ybrock Could you please submit a pull request.

ybrock commented 4 years ago

My pull request was merge. We can close the issue. Thanks for the merge