ensuring sssd.conf consistency during first Puppet run

sgnl05 / sgnl05-sssd

Puppet module for SSSD

https://forge.puppet.com/sgnl05/sssd

GNU General Public License v3.0

17 stars 77 forks source link

Closed ndelic0 closed 8 years ago

edestecd commented 8 years ago

Interesting, I didn't think of authconfig modifying the config file. That makes sense though.

Can you add a line to the spec test that makes sure this order happens in the RedHat blocks...

ndelic0 commented 8 years ago

All check finally passed!

edestecd commented 8 years ago

If you want to bump the line length requirement just a bit, I wouldn't be opposed: Its set here: https://github.com/sgnl05/sgnl05-sssd/blob/master/.rubocop.yml#L26

I often bump it to 100

edestecd commented 8 years ago

@curly8 can you add the same line to the RedHat 7 block also?

ndelic0 commented 8 years ago

Done. Had to bump the Line Length to 105. Please review.

edestecd commented 8 years ago

Looks good