Stop sorting config keys for newer ruby versions.

sgnl05 / sgnl05-sssd

Puppet module for SSSD

https://forge.puppet.com/sgnl05/sssd

GNU General Public License v3.0

17 stars 78 forks source link

Closed gizmoguy closed 8 years ago

gizmoguy commented 8 years ago

For ruby versions > 1.9.3 use order specified by user for configuration, otherwise sort it alphabetically.
Remove extraneous whitespace.

gizmoguy commented 8 years ago

Sorry submitting on a different PR to #12 but I messed up my rebase.

I've performed the changes asked for and added a bunch of tests because I didn't have any machines to test on with older ruby versions.

I'll also look into fixing the lint issues picked up by rubocop.

edestecd commented 8 years ago

Other then the rubocop errors, it looks good to me.

gizmoguy commented 8 years ago

Fixed most of them.

What do we think about "Style/RegexpLiteral: Use %r around regular expression.".

Usually I prefer using slashes as the regexp delimiter?

edestecd commented 8 years ago

I always go with the community recommendation. Unless you have a really good reason not to.

edestecd commented 8 years ago

Its much cleaner if you don't have to use the escapes. Escapes make it harder to read.

gizmoguy commented 8 years ago

Force of habit really, which isn't a good enough reason.

I have now fixed all rubocop issues and tests seem to all pass now.

edestecd commented 8 years ago

Super. Thanks for the contribution!