search

sgnl05 / sgnl05-sssd

Puppet module for SSSD
https://forge.puppet.com/sgnl05/sssd
GNU General Public License v3.0
17 stars 77 forks source link

Fix newline under each section #18

Closed sgnl05 closed 8 years ago

sgnl05 commented 8 years ago

@edestecd I'm trying to fix an issue where every section in sssd.conf gets written without being split by a new line. Do you have this issue? Can you please test how this commit affects your setup?

edestecd commented 8 years ago

@sgnl05 yes I saw that awhile back. I think maybe the ruby 1.9.3 ordering introduced it. I didn't complain at the time, b/c it didn't break anything. sssd does not seem to care.

It definitely used to have newlines between sections and I do think it is more readable that way. What you have looks correct to me... We have one big change in the pipeline at the moment, but I'll give it a go after that. Should be in the next day or so.

edestecd commented 8 years ago

@sgnl05 I tested this in our environment with no issue. Login continues to work as expected on RHEL 5,6,7 and Ununtu 14.04 LTS

sgnl05 commented 8 years ago

Great, thanks!