sgnl05 / sgnl05-sssd

Puppet module for SSSD
https://forge.puppet.com/sgnl05/sssd
GNU General Public License v3.0
17 stars 77 forks source link

No option to skip package installation #19

Closed disconn3ct closed 7 years ago

disconn3ct commented 8 years ago

We use another module that installs the package but does minimal configuration. Since there is no option to skip package installation, we are getting duplicate resource errors. (Using ensure_packages would solve it without major changes.)

sgnl05 commented 8 years ago

Wouldn't it be sufficient to include sssd::config and sssd::service instead of the main class?

disconn3ct commented 7 years ago

Maybe I'm missing something (not the first time by far) but doesn't that make it impossible to override sssd::params without switching over to Hiera?

tdevelioglu commented 7 years ago

Better let the sssd::config and sssd:service stay private (preferably even unparameterized) and let only the public interface(s) allow configuring the parameters of the module.

I propose adding a $package_manage flag (default: true) to the main class that can prevent declaring the package resource.

dannygoulder commented 7 years ago

26

sgnl05 commented 7 years ago

Thanks @dannygoulder !