search

sgnl05 / sgnl05-sssd

Puppet module for SSSD
https://forge.puppet.com/sgnl05/sssd
GNU General Public License v3.0
17 stars 77 forks source link

Fix for #19 #20

Closed disconn3ct closed 8 years ago

disconn3ct commented 8 years ago

This fixes #19 by using ensure_packages and ensure_resources.

edestecd commented 8 years ago

I am in favor of this change in general. :thumbsup: Thank you for your contribution and hard work! It is much appreciated.

If you could make the linter happy and fix the indentation, that would be great. https://travis-ci.org/sgnl05/sgnl05-sssd/jobs/139792710#L225

You can run the test suite on your own machine by doing the following:

bundle install
rake
edestecd commented 8 years ago

Looks like ensure_resource was not introduced until version 2.5.0 of stdlib. We currently have it pinned to >= 2.3.0 in metadata.json. We probably need to update that as well.

sgnl05 commented 8 years ago

Closing this until checks and conflicts are resolved.