sgnl05 / sgnl05-sssd

Puppet module for SSSD
https://forge.puppet.com/sgnl05/sssd
GNU General Public License v3.0
17 stars 77 forks source link

Module design and v1 #21

Closed ghoneycutt closed 8 years ago

ghoneycutt commented 8 years ago

Hi,

I'm interested in using your module and would like to know if you would accept a refactor to remove the anchor and params patterns. The current design needlessly separates out the classes, where each class should encapsulate specific functionality as opposed to just a piece of functionality that is glued together with the anchor pattern. It makes the code harder to read and understand. If you are open to this, I would be happy to do the refactor and submit more spec tests.