sgnl05 / sgnl05-sssd

Puppet module for SSSD
https://forge.puppet.com/sgnl05/sssd
GNU General Public License v3.0
17 stars 77 forks source link

Fix Service[oddjobd] failing to start #22

Closed jeffmccune closed 8 years ago

jeffmccune commented 8 years ago

Without this patch the initial Puppet run fails with the following error message:

Error: Could not start Service[oddjobd]: Execution of '/sbin/service oddjobd
start' returned 1: Starting oddjobd: [FAILED]

The cause of this error is that the messagebus service is not started. This patch addresses the problem by adding optional management of dependent services to the sssd::services class. Since these dependencies aren't strictly related to sssd they can easily be overridden by setting sssd::service_dependencies to an empty array in Hiera.

edestecd commented 8 years ago

hmm, I have not seen this. Can you help by indicating the OS and version you are using?

jeffmccune commented 8 years ago

CentOS release 6.7 (Final)

I think the issue is the base image I’m working with has the messagebus service disabled and stopped. It needs to come online before oddjobd and I didn’t want to write an entire module just to handle this edge case so I took the approach of specifying it as a dependency by default that can be overridden if messagebus needs to be managed somewhere else in the catalog. Curious what you think and happy to take a different approach to solve the problem if you think it’s best.

Cheers, -Jeff

ghoneycutt commented 8 years ago

@jeffmccune You can fix travis failing by incorporating these lines into the Gemfile

https://github.com/Ericsson/puppet-module-cron/blob/master/Gemfile#L27-L39

jeffmccune commented 8 years ago

@jeffmccune You can fix travis failing by incorporating these lines into the Gemfile https://github.com/Ericsson/puppet-module-cron/blob/master/Gemfile#L27-L39

@ghoneycutt Gemfile updated in 64df4f12a837dd387ac20e58a518a6084d64ee5b

ghoneycutt commented 8 years ago

+1

@sgnl05 Could you please take a look? I think we are ready for merge.

sgnl05 commented 8 years ago

Looks good. Thanks!

ghoneycutt commented 8 years ago

Thanks @sgnl05

Could you please tag this as a new release?

sgnl05 commented 8 years ago

Fixed

ghoneycutt commented 8 years ago

Released in 0.3.1

Thank you everyone!