search

sgnl05 / sgnl05-sssd

Puppet module for SSSD
https://forge.puppet.com/sgnl05/sssd
GNU General Public License v3.0
17 stars 77 forks source link

Added ensure_resource and ensure_packages to avoid collisions #26

Closed dannygoulder closed 7 years ago

dannygoulder commented 7 years ago

Needs newer version of puppetlabs-stdlib which I have added to the metadata.json.

Puppetlabs-stdlib 4.x only works with Puppet 3.x which is already a minimum requirement for this module.

sgnl05 commented 7 years ago

This looks good too me. @edestecd do you have anything to add or should we just merge this?

edestecd commented 7 years ago

Everything looks great! @dannygoulder squashing all your commits to one or two commits would be nice, if you are comfortable with that...

Looks like github can squash for us, if you prefer...

dannygoulder commented 7 years ago

GitHub squash is a good plan. Cheers

On 3 Nov 2016, at 4:20 pm, Chris Edester notifications@github.com wrote:

Everything looks great! @dannygoulder squashing all your commits to one or two commits would be nice, if you are comfortable with that...

Looks like github can squash for us, if you prefer...

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

edestecd commented 7 years ago

@dannygoulder thanks for the contribution!

dannygoulder commented 7 years ago

You're welcome. Thanks for the great work on the module.

On 4 Nov 2016, at 12:06 am, Chris Edester notifications@github.com wrote:

@dannygoulder thanks for the contribution!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.