sgnl05 / sgnl05-sssd

Puppet module for SSSD
https://forge.puppet.com/sgnl05/sssd
GNU General Public License v3.0
17 stars 76 forks source link

Setting ensure => absent now further disables sssd #32

Closed machad closed 7 years ago

machad commented 7 years ago
ghoneycutt commented 7 years ago

Hi @machad

Try running puppet-lint -f manifests/* to automatically fix the style issues. That should make Travis happy.

machad commented 7 years ago

@ghoneycutt Thanks. I've done that and committed the update. How do I trigger a re-check with travis?

machad commented 7 years ago

It looks like the following test is failing:

https://travis-ci.org/sgnl05/sgnl05-sssd/jobs/204363675

Unfortunately, it's a bit unclear to me where the actual issue is short of maybe something specific to Ruby 1.9.3. If you can give me a hint, I'll be happy to dig in.

edestecd commented 7 years ago

We meed a new exclude in the .travis.yml file. Apparently the newest version of puppet 4.9.x does not support ruby 1.9.3...

edestecd commented 7 years ago

Adding this should do it:

- rvm: 1.9.3
  env: PUPPET_GEM_VERSION="~> 4" CHECK=test
ghoneycutt commented 7 years ago

opened PR #33 to fix this issue

ghoneycutt commented 7 years ago

@edestecd Puppet 4.9 also drops support for ruby 2.0.0, though this module does not support that version.

machad commented 7 years ago

Thanks, @ghoneycutt. I'll keep an eye on that and once it's merged I'll pull it into this branch.

sgnl05 commented 7 years ago

Thanks! :+1: