search

sgnl05 / sgnl05-sssd

Puppet module for SSSD
https://forge.puppet.com/sgnl05/sssd
GNU General Public License v3.0
17 stars 76 forks source link

Updated Module to Puppet >= 4.X #40

Closed dpattmann closed 7 years ago

dpattmann commented 7 years ago

Puppet 3.X is deprecated - This PR should fix #36

ghoneycutt commented 7 years ago

The open PR's should be merged or closed and the open issues addressed. Luckily there are only a couple of each.

edestecd commented 7 years ago

@ghoneycutt, I agree with the rest of your suggestions, but should we hold up this MR to get all of that done? If @dpattmann is willing to do it, then great, but otherwise we can move that stuff to other issues/PRs and not cut 2.0.0 until its all in.

ghoneycutt commented 7 years ago

I would like my PR that was merged before you branched this to be included.

ghoneycutt commented 7 years ago

@edestecd having multiple classes makes things harder to read and understand. There is no point for having all these subclasses or the params class. What it really means is that I have to have all of them open to understand what is happening. They don't have any real value on their own. The params class only makes sense if you have multiple classes that need to share information, as this is a simple module that is only invoked with include ::sssd there is no need for it either.

dpattmann commented 7 years ago

@edestecd @ghoneycutt I would prefer to merge this PR first and then have another PR to cleanup the module.

sgnl05 commented 7 years ago

Thanks for the contribution!