search

sgnl05 / sgnl05-sssd

Puppet module for SSSD
https://forge.puppet.com/sgnl05/sssd
GNU General Public License v3.0
17 stars 76 forks source link

No service refresh after conf change #43

Closed tux-o-matic closed 6 years ago

tux-o-matic commented 6 years ago

Why is there no notify or subscribe link between the File resource for sssd.conf and the Service sssd?

edestecd commented 6 years ago

That is handled here: https://github.com/sgnl05/sgnl05-sssd/blob/master/manifests/init.pp#L77

The ~> says to notify and services in the class { '::sssd::service': }

tux-o-matic commented 6 years ago

I'd say that defines order. Not proper subscription or notify. Try debugging a config change and there won't be any service refresh triggered.

edestecd commented 6 years ago

-> defines just order (require) ~> defines notify/subscribe

https://docs.puppet.com/puppet/5.1/lang_relationships.html#syntax-chaining-arrows

tux-o-matic commented 6 years ago

Yes, on resource. Here on classes it's not the same behaviour. If it were, I'd expect the logs to show a refresh event but it doesn't.

edestecd commented 6 years ago

That has been working on classes for quite some time and there are many examples of modules that use this pattern. What version of puppet are you using? Perhaps it is broken or depreciated in some version?

tux-o-matic commented 6 years ago

Witnessed that in 4.10. Change to sssd.conf did not lead to a service refresh.

tux-o-matic commented 6 years ago

Can we re-open this issue and have this relation changed to really trigger a service refresh?