sgnl05 / sgnl05-sssd

Puppet module for SSSD
https://forge.puppet.com/sgnl05/sssd
GNU General Public License v3.0
17 stars 76 forks source link

Gentoo support #49

Closed optiz0r closed 6 years ago

optiz0r commented 6 years ago

Adds basic support for Gentoo and derivatives. Tested on Sabayon Linux.

I've added basic tests (just a copy of the Debian tests), but I'm unable to run these to confirm if they work:

$ /opt/puppetlabs/puppet/bin/rake spec
An error occurred while loading ./spec/classes/init_spec.rb.
Failure/Error: require 'rspec-puppet-facts'

LoadError:
  cannot load such file -- rspec-puppet-facts
$ sudo  /opt/puppetlabs/puppet/bin/gem install rspec-puppet-facts
Fetching: facter-2.5.1.gem (100%)
facter's executable "facter" conflicts with /opt/puppetlabs/puppet/bin/facter
Overwrite the executable? [yN]  n
ERROR:  Error installing rspec-puppet-facts:
        "facter" from facter conflicts with /opt/puppetlabs/puppet/bin/facter
ghoneycutt commented 6 years ago

@optiz0r run the following to install the dependencies

gem install bundler # once to install bundler
bundle install # you'll do this in the directory of each ruby project with a Gemfile

then you run commands with the bundle exec prefix.

bundle exec rake test
optiz0r commented 6 years ago

@ghoneycutt Thanks, don't know why I didn't think of that earlier

ghoneycutt commented 6 years ago

+1

Code looks good, though suggest we have someone else test it on Gentoo if possible.

ghoneycutt commented 6 years ago

Hi @optiz0r

Apologies on the merge issue. We've done a major version change and started using data in modules to making supporting other platforms easier. Would you be interested in adding these to the latest version of the module? It seems that Gentoo does not run any specific pam commands like the other platforms, so should be just adding hiera data to the data/ directory and potentially a fail line like the other platforms in the main class.

optiz0r commented 6 years ago

I'll update this PR to account for the upstream changes when I have the chance, yes.

ghoneycutt commented 6 years ago

@optiz0r I added support for Gentoo in PR #64 though I do not have a Gentoo system to test this on. Could you please confirm if this works?

ghoneycutt commented 6 years ago

Gentoo support added in 2.4.0