Data in module

[ghoneycutt]

Do not merge

[ghoneycutt]

Hi @sgnl05

Spent the weekend refactoring the module. Still not done, but wanted to give you a preview.

• Ensure all params use data types
• Remove deprecated anchor pattern
• Remove deprecated params.pp pattern in favor of data in module
• Data in module is using Hiera 5
• Testing now covers all supported platforms
• Testing now covers failing on unsupported platforms
• Use new fact names, so $::facts['os']['family'] instead of $::osfamily.

Still to do:

Testing is not complete. Needs parameter type validation as well as testing the effects of each param.

[ghoneycutt]

And a big thanks for making me a collaborator on this module! :)

[ghoneycutt]

@phil-friderici

Could you please add tests and fix this module up further for our friends in NY?

[Phil-Friderici]

@ghoneycutt with pleasure :)

[ghoneycutt]

@sgnl05 I think this is about ready to merge. Would be great if you could run it on some of your systems and verify things are OK.

[ghoneycutt]

@Phil-Friderici Thanks for the puppet-strings PR and all the rest!

[ghoneycutt]

@sgnl05 I've been running this for the past week and no changes to my config. Could you please merge?

[sgnl05]

Haven't had time to test yet, but I'll will as soon as possible. Changes look very good anyway. Thanks @ghoneycutt and @Phil-Friderici !

[sgnl05]

PS, feel free to tag a new release when you think it's ready. :)

[ghoneycutt]

Released in 2.2.0