sgnl05 / sgnl05-sssd

Puppet module for SSSD
https://forge.puppet.com/sgnl05/sssd
GNU General Public License v3.0
17 stars 76 forks source link

Package[libpam-runtime] is already declared #81

Closed mergwyn closed 5 years ago

mergwyn commented 5 years ago

I got the error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation Error: Error while evaluating a Function Call, Duplicate declaration: Package[libpam-runtime] is already declared at (file: /etc/puppetlabs/code/environments/production/modules/webmin/manifests/install.pp, line: 5); cannot redeclare (file: /etc/puppetlabs/code/environments/production/modules/sssd/manifests/init.pp, line: 127) (file: /etc/puppetlabs/code/environments/production/modules/sssd/manifests/init.pp, line: 127, column: 5) on node foxtrot.theclarkhome.com

Both modules use ensure_packages to try and avoid this problem, and I suspect this error is caused by the modules using different parameter to ensure_packages, in particular the 'require' attribute below.

if $extra_packages {
    ensure_packages($extra_packages,
      {
        ensure  => $extra_packages_ensure,
        require => Package[$sssd_package],
      }
    )
  }

I think that the 'require' is redundant but I wanted to get your view before a I created a pull request to make this change.