search

sgnl05 / sgnl05-sssd

Puppet module for SSSD
https://forge.puppet.com/sgnl05/sssd
GNU General Public License v3.0
17 stars 78 forks source link

Add support for Fedora versions 29 and 30 #92

Closed jmciver closed 5 years ago

jmciver commented 5 years ago

Add support for authselect enabled Fedora 29 and 30. Backwards compatibility is maintained for Fedora 27 and older, which used authconfig.

New unittests for Fedora 29 and 30 have been added. Conditional tests previously based on the "osfamily" fact evaluating to RedHat have been converted to use "os.name", which evaluates differently for RedHat and Fedora operating systems.

Default values for (enable|disable)_mkhomedir_flags are now obfuscated by the use of a params class. The default values have been added to each parameter's YARD docstring.

ghoneycutt commented 5 years ago

Hi @jmciver Thank you very much for your contribution! I've made some review notes.

jmciver commented 5 years ago

Changes have been made as per @ghoneycutt's recommendations. All comments made in the resolution process have been squashed.

ghoneycutt commented 5 years ago

This is looking good! It should also have functional testing with travis like this - https://github.com/sgnl05/sgnl05-sssd/blob/master/.travis.yml#L19-L30

You'll need a fedora docker containers in https://github.com/sgnl05/sgnl05-sssd/tree/master/spec/acceptance/nodesets

ghoneycutt commented 5 years ago

Awesome work @jmciver !!

jmciver commented 5 years ago

Thanks @ghoneycutt for the feedback!

I'll author another pull request once an official Fedora 30 puppet-agent becomes available.