PWP - Murder Mystery Summary

Criteria 1: Valid Python Code

Score Level: 4 Exceeds Expectations
Comment(s): Your code runs and does not run into any issues or throw any errors. Well done!

Criteria 2: Implementation of Project Requirements

Score Level: 4 Exceeds Expectations
Comment(s): You were able to create all the necessary functions and classes for this project.

Criteria 3: Software Architecture

Score Level: 4 Exceeds Expectations
Comment(s): Nice job creating and separating the tasks of each method. It is clear upon looking at them what each one is doing!

Criteria 4: Uses Python Language Features

Score Level: 3 Meets Expectations
Comment(s): Great job using the Python language features throughout your code. I noticed that you didn’t need to use a and b in your string formatting in TextSample’s repl method, and could have kept it empty like so: return "{}'s text sample with average sentence length {}".format(self.author, self.average_sentence_length) to make it cleaner and easier to read. Another method I would have liked to see you use more in your code would be the get() method.

Criteria 5: Produces Accurate Output

Score Level: 2 Approaches Expectations
Comment(s): Your code did not produce the correct output - the murderer is meant to be Lily Trebuchet. Here’s the solution code for reference: https://s3.amazonaws.com/codecademy-content/programs/programming-with-python/capstone-solutions/Murder+Mystery(1).ipynb

Overall Score: 17/20

Overall, stellar work on this project! I can see you understand the fundamentals of Python and how to implement it to solve certain tasks. I love your approach to solving the various obstacles in this project, and I hope you keep up the great work! 👍

Thank you for the feedback.

I will check out the solution to see where my math went wrong.

I am traveling but will be back in a week. If I can get to it, can I submit the other project for review as well?

Thank you,

Stan

On Sun, Jun 24, 2018 at 1:46 PM Jen Zhu notifications@github.com wrote:

Criteria 1: Valid Python Code

Score Level: 4 Exceeds Expectations

Comment(s): Your code runs and does not run into any issues or throw any errors. Well done!

Criteria 2: Implementation of Project Requirements

Score Level: 4 Exceeds Expectations

Comment(s): You were able to create all the necessary functions and classes for this project.

Criteria 3: Software Architecture

Score Level: 4 Exceeds Expectations

Comment(s): Nice job creating and separating the tasks of each method. It is clear upon looking at them what each one is doing!

Criteria 4: Uses Python Language Features

Score Level: 3 Meets Expectations

Comment(s): Great job using the Python language features throughout your code. I noticed that you didn’t need to use a and b in your string formatting in TextSample’s repl method, and could have kept it empty like so: return "{}'s text sample with average sentence length {}".format(self.author, self.average_sentence_length) to make it cleaner and easier to read. Another method I would have liked to see you use more in your code would be the get() method.

Criteria 5: Produces Accurate Output

Score Level: 2 Approaches Expectations

Comment(s): Your code did not produce the correct output - the murderer is meant to be Lily Trebuchet. Here’s the solution code for reference: https://s3.amazonaws.com/codecademy-content/programs/programming-with-python/capstone-solutions/Murder+Mystery(1).ipynb

Overall Score: 17/20

Overall, stellar work on this project! I can see you understand the fundamentals of Python and how to implement it to solve certain tasks. I love your approach to solving the various obstacles in this project, and I hope you keep up the great work! 👍

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/sgolanka/pwp-capstones/issues/1, or mute the thread https://github.com/notifications/unsubscribe-auth/ADlV2IQb7xqxrjU4x2TazBLsJOMLO6h1ks5t_9BbgaJpZM4U1PMr .

sgolanka / pwp-capstones