search

sgotti / glide-vc

Glide vendor cleaner
MIT License
53 stars 10 forks source link

*: add support for testImports #17

Closed runcom closed 8 years ago

runcom commented 8 years ago

This PR does 2 things:

  1. Update glide libraries to v0.11.1 to access the new testImport variable (still called DevImport but the json is unmarshalled from testImport)
  2. Fix glide-vc not to remove tests vendor directories as found in https://github.com/opencontainers/image-spec/pull/181#discussion_r71890312

Follow up PR I'm willing to do if @sgotti is ok - adding a file to choose whether to remove testImport vendors or no (I'll gladly do it in this PR as well if you wish) Nevermind, I did that by adding a new flag no-test-imports which does the cleanup of testImport dependencies (default if false as I expect people to vendor their test deps)

Signed-off-by: Antonio Murdaca runcom@redhat.com

sgotti commented 8 years ago

@runcom Thanks! LGTM!

runcom commented 8 years ago

@sgotti :smile_cat: