search

sgpthomas / hourglass

GNU General Public License v3.0
26 stars 12 forks source link

Use user preference for AM/PM or 24h #193

Open ChildishGiant opened 2 years ago

ChildishGiant commented 2 years ago

The user can chose if AM/PM or 24h is used but hourglass always uses a mix image

24 hour: image

AM/PM: image

ryonakano commented 2 years ago

This is because Flatpak apps can't access to the host's gsettings. We uses the following method to detect the host's time format:

https://github.com/sgpthomas/hourglass/blob/6d2570b1a6fe496924b221bcb53a31a27b036292/src/Widgets/Alarm.vala#L72-L80

This works if the app installed to /usr/share/bin, but it won't work on the sandboxed environment. Hopefully if https://github.com/elementary/granite/pull/528 is merged we can fix this issue but the PR is not reviewed/merged yet. :cry:

ChildishGiant commented 2 years ago

Ah, I thought there may be some system-talk-name finish arg that could expose it but I imagine you've looked into that. Hopefully the linked PR gets merged then 😊