Alarm: Ring only on repeated days

sgpthomas / hourglass

GNU General Public License v3.0

26 stars 12 forks source link

Alarm: Ring only on repeated days #198

Closed nakotami closed 2 years ago

nakotami commented 2 years ago

Fixes #197

Note: This introduces a bug where if there is more than one repeat day and the current day is in between the two, it will set the date label to the day closest to Monday. If anyone wants to improve my changes, go right ahead.

nakotami commented 2 years ago

Thank you for the changes, I'm quite new to elementary so I didn't really know about the Linter.

ryonakano commented 2 years ago

Also we uses dev branch for development so I changed the base branch of your PR and merged the latest commits. 🙏

nakotami commented 2 years ago

One more thing before this pull request is merged, I'm concerned that https://github.com/sgpthomas/hourglass/pull/198#discussion_r781641683 may overflow the date label or look unappealing if there are too many repeat days. I'll test this when get home in around 7 hours.

nakotami commented 2 years ago

Think we might have to revert that change 😬.

ryonakano commented 2 years ago

OK, then let's revert that change and only show the day the alarm rings next there. :sweat_smile: