sgraf812 / feed-gipeda

Daemon for watching for new commits to multiple git repositories and feeding benchmark runs into gipeda
BSD 3-Clause "New" or "Revised" License
5 stars 1 forks source link

Use `chroot` and related friends for some notion of security #16

Closed sgraf812 closed 7 years ago

sgraf812 commented 8 years ago

The following scenario is really bad for security reasons:

  1. A third party gets a repository accepted to the configured feed-gipeda.yaml
  2. The third party changes its benchmarkScript to something malicious
  3. The script can trivially access the whole build slave.

Means for damage mitigation:

Question is if this should me moved into feed-gipeda or is rather an obligation of the surrounding build slave architecture. In any case, as long as the slave node is on a separate machine isolated from the master node, tampering with the generated site should be impossible.

sgraf812 commented 7 years ago

I'm closing this for now, as I'm playing around with docker containers for benchmark slaves, which should mitigate most of the problems: https://hub.docker.com/r/sgraf812/haskell-bench-slave/