Add a timeout for benchmarks - Githubissues

sgraf812 / feed-gipeda

Daemon for watching for new commits to multiple git repositories and feeding benchmark runs into gipeda

BSD 3-Clause "New" or "Revised" License

5 stars 1 forks source link

Add a timeout for benchmarks #17

Closed sgraf812 closed 8 years ago

sgraf812 commented 8 years ago

Some commit might unintendedly introduce a non-terminating benchmark. That should not choke a slave.

Instead, there should be a --timeout config parameter, defaulting to something like 30 minutes (that will unfortunately include build time).

Actually, the benchmark script should enforce this, but feed-gipeda should be able to cope with malevolent (or just badly implemented, like cloben currently :)) benchmark scripts.

sgraf812 commented 8 years ago

Well, it's implemented now, but doesn't seem to work. Have to dig into this.

sgraf812 commented 8 years ago

Weird.

It doesn't seem to work at all on the Debian rack
It seems to kill the child node on my Ubuntu VM, but not its child processes, e.g. cloben and its sub proccesses

Probably should have used a proper shell script library after all for forking.

sgraf812 commented 8 years ago

Although I cancel the Async handle, there doesn't seem to be thrown an exception on the slave node. Might have to pass the timeout to the slave node explicitly.

sgraf812 commented 8 years ago

Well, that took more effort than I thought, but it works in 3d113f57b9ce600bd2df964c3314b9328f369706.