support Window command prompt

sgreben / jp

dead simple terminal plots from JSON data. single binary, no dependencies. linux, osx, windows.

MIT License

1.32k stars 33 forks source link

support Window command prompt #11

Closed mattn closed 6 years ago

mattn commented 6 years ago

2d7c214c47290e7f

Width should be lesser 1 columns on Windows command prompt since output on maximum column make empty line in next line.
In several country, width of border letter return 2.

sgreben commented 6 years ago

Hey, many thanks for the PR. I've used it as the spec when working on 1.1.0. I've opted to use conditional builds instead of runtime branches to set the width and border runes. Could you give the 1.1.0 release a try?

mattn commented 6 years ago

Seems good to me but someone may expect Unicode borders on Windows on non CJK countries. This is because why I checked with runewidth.StringWidth(primitives.HorizontalLine).

mattn commented 6 years ago

Seems good to me but someone may expect Unicode borders on Windows on non CJK countries. This is because why I checked with runewidth.StringWidth(primitives.HorizontalLine).