search

sgreenholtz / Event-Spider

A web scraping application for events
MIT License
0 stars 0 forks source link

Design/Code Review 2 #4

Open TheJohnHanson opened 7 years ago

TheJohnHanson commented 7 years ago

Design/Code Review 2

Project: Event Spider

Developer: Sebastian Greenholtz

Reviewer: John Hanson

Category Criteria Analysis/Comments
Running application
Describe the application functionality that has been built and is working. I know Sebastians application has ran in the past, but currently he had an issue that was preventing his application from launching. He was able to run his tests and we were able to see (most) of them pass.
What is good? Large code base in place. Sebastian has done a lot of work on his current application. It is very well designed.
What could be improved? Wish I could have seen it run. NA
Unit Tests
What are the code coverage statistics?
Are @Before/@BeforeClass/@After/@AfterClass used to reduce redundant code? Yes, Sebastian has fully implemented hibernate
JSPs
Is templating used to eliminate rundandant code(for example, header.jsp, footer.jsp, etc.) Yes
What is good? A Lot of JSPs
What could be improved? Nothing
Code quality
Are methods single-purpose? Yes, the code is designed very well
Are classes appropriately-sized classes (no monster classes)? Yes
Are the same lines of code repeated at all? No
Do any classes perform very similar functions that could be candidates for super/subclass relationships? Not in the current state
Are any values hard-coded that should be in a properties file? No
Are variable names descriptive? Yes
Are there many branches or loops that could be simplified or broken up into smaller methods? No
Do the DAOs use Hibernate? No hard-coded sql! yes!
Has log4J been added? Yes
Are there logging statements in the code? Yes
Are appropriate logging levels used? Info, debug, error, for example. Yes
Are there any System.out.printlns in the code? No
Other comments/notes? Great Work!
Web Service/API integration Which web service/api is being used? A few other packages to help crawl the web
Is the integration built? No
If so, evaluate the integration code. What is good? What could use improvement?
Independent research topic What is the developer's independent research topic? Spring
Has the topic been implemented in the project? Yes
If so, evaluate the implementation. What is good? What could use improvement? Not familiar with it so hard to tell
Key takeaways List at least 3 things you learned while reviewing this project that will help you in your own project. Project structure. dao usage. better tests.
sgreenholtz commented 7 years ago

Anything that could be improved?