search

sgreenholtz / Event-Spider

A web scraping application for events
MIT License
0 stars 0 forks source link

Code Review #2 #7

Open bvue opened 7 years ago

bvue commented 7 years ago

Design/Code Review 2

Project: EVent Spider

Developer: Sebastian

Reviewer: Bao

Category Criteria Analysis/Comments
Running application
Describe the application functionality that has been built and is working. At the time, it was not working
What is good? A lot of code established for the project
What could be improved? Get the code to run
Unit Tests
What are the code coverage statistics? NA
Are @Before/@BeforeClass/@After/@AfterClass used to reduce redundant code? Yes
JSPs
Is templating used to eliminate rundandant code(for example, header.jsp, footer.jsp, etc.) Doesn't exist yet
What is good? A few JSPs are already written. Just need to add a few to round out the application
What could be improved? See above
Code quality
Are methods single-purpose? Yes
Are classes appropriately-sized classes (no monster classes)? Yes
Are the same lines of code repeated at all? No
Do any classes perform very similar functions that could be candidates for super/subclass relationships? No
Are any values hard-coded that should be in a properties file? No
Are variable names descriptive? yes
Are there many branches or loops that could be simplified or broken up into smaller methods? No
Do the DAOs use Hibernate? No hard-coded sql! Yes
Has log4J been added? Yes
Are there logging statements in the code? I did not see them, but I may have missed them? There were a lot of classes.
Are appropriate logging levels used? Info, debug, error, for example. NA
Are there any System.out.printlns in the code? No
Other comments/notes?
Web Service/API integration Which web service/api is being used? NA
Is the integration built? NA
If so, evaluate the integration code. What is good? What could use improvement?
Independent research topic What is the developer's independent research topic? Spring
Has the topic been implemented in the project? Yes
If so, evaluate the implementation. What is good? What could use improvement? I am not familiar with Spring.
Key takeaways List at least 3 things you learned while reviewing this project that will help you in your own project. Add more JSPs and classes. Make more progress in my project.