search

sgrid / pysgrid

Python tools for sgrid
BSD 3-Clause "New" or "Revised" License
10 stars 16 forks source link

Faces and centers #73

Open ocefpaf opened 8 years ago

ocefpaf commented 8 years ago

@ayan-usgs, when browsing the namespace one can easily find everything that is related to nodes with sgrid.node<tab> (sgrid.node_coordinates, sgrid.node_dimensions, sgrid.node_lon, sgrid.node_lat, and sgrid.node_padding). However, when doing the same for the center we only find sgrid.center_lon and sgrid.center_lat.

Does it make sense to rename the sgrid.face_{coordinate, dimensions, padding} to sgrid.center_{coordinate, dimensions, padding}? Note that sgrid.faces is always none!

ayan-usgs commented 8 years ago

@ocefpaf,

Yep, doing the rename makes sense.

ocefpaf commented 8 years ago

Thanks @ayan-usgs!

FYI I am experimenting a new API and ways to make all slices and computations lazy:

http://nbviewer.jupyter.org/gist/ocefpaf/28d9279479022454bb99

It is not ideal yet because of a masking issue. If I can figure that out things will be much easier for sci-wms.

ocefpaf commented 8 years ago

Can you cross- reference the PR that did the rename? I am a bit lost.

ayan-usgs commented 8 years ago

The rename happened in #72. The variables were named face_coordinates, face_dimensions, etc.

ocefpaf commented 8 years ago

I center_{lon,lat} are still there. The question was regarding re-naming those.

ayan-usgs commented 8 years ago

Sorry. Didn't totally re-read the question... :sob: