Use Diesel 1.4.4 in "getting started" example and all GitHub links

sgrif / diesel.rs-website

MIT License

32 stars 97 forks source link

Use Diesel 1.4.4 in "getting started" example and all GitHub links #100

Closed issyl0 closed 4 years ago

issyl0 commented 4 years ago

Hey! Thanks for building Diesel! 👏

I copied and pasted the Getting Started examples, and the Rust plugin from my editor told me that the versions were out of date. Turns out that the GitHub links also pointed to tag 1.3.0 not the latest, 1.4.4.
Keeping these up to date is a little bit of a maintenance burden, but I couldn't find such a thing as a "latest" tag.
Also correctly capitalize GitHub. It's trivial, but I noticed one and then I noticed them all. 😄

Unfortunately I've been unable to test the changes locally - installing Ruby 2.3.3 informed me that it's EoL, I couldn't build the JSON gem under that version, and so Middleman was unhappy. I continued by upgrading to Ruby 2.6.6 and bundle updateing everything, but I figured that was a little bloaty for this PR as Middleman warned about a bunch of deprecations in v4.3. If you'd like me to do that in a separate PR to save you the extra work, I can do.

JohnTitor commented 4 years ago

Unfortunately I've been unable to test the changes locally - installing Ruby 2.3.3 informed me that it's EoL, I couldn't build the JSON gem under that version, and so Middleman was unhappy. I continued by upgrading to Ruby 2.6.6 and bundle updateing everything, but I figured that was a little bloaty for this PR as Middleman warned about a bunch of deprecations in v4.3. If you'd like me to do that in a separate PR to save you the extra work, I can do.

It's also my pain :/ I'd be happy to see PR(s) for that and it'd also be great if we could setup CI. Any thoughts @weiznich?

issyl0 commented 4 years ago

So I looked into more of the deprecations and build failures and there's a lot of CSS (SASS? SCSS?) stuff that I just don't understand - I have very little idea about "frontend" stuff, much less "modern frontend" stuff. So I'm going to leave the Ruby and gem updates to you folks! If it helps you progress, I've got a branch here with a few commits on it.

weiznich commented 4 years ago

Having a CI (or even auto deploy) for repo would be great. I remember that I had everything working locally some time ago, but it has been a while 🙈 (Beside of that, I also more a "backend" guy, so I would be happy about any help here.

JohnTitor commented 4 years ago

@issyl0 At a glance, your work looks good to me. After some debugging, it seems bitters stylesheets are also outdated and I guess we need some more fixes to display contents correctly :/

issyl0 commented 4 years ago

@JohnTitor Thanks! That's good to hear - I basically did what the Google searches told me. :joy: I noticed that the boxes don't display any more for the "why" featuresets. But that's undoubtedly related to what you said about everything being outdated. I'll raise a draft PR as a place for everyone to figure it out together.