search

sgrif / diesel.rs-website

MIT License
32 stars 97 forks source link

Adding a small aside in the getting started doc on how to do connection pooling #149

Closed chusteven closed 2 years ago

chusteven commented 2 years ago

This was requested in https://github.com/diesel-rs/diesel/issues/1951 and alongside https://github.com/diesel-rs/diesel/pull/3123 I think should be enough for folks to get started.

Not entirely sure about the language I'm using as I'm still relatively new to Rust but wanted to get some early feedback. Also, I don't actually know if the markdown renders as I expect (particularly the code blocks inside aside tags) -- I tried running make page but don't have pandoc installed on my machine right now so I'll get to work on that soon.

chusteven commented 2 years ago

Hmm not sure how to request a reviewer as this is in a different organization than diesel-rs ; sorry for the direct ping but maybe @weiznich can help out?

chusteven commented 2 years ago

See comments here https://github.com/diesel-rs/diesel/pull/3123#issuecomment-1091780006 for why this is no longer needed