sgrif / diesel.rs-website

MIT License
32 stars 97 forks source link

Increses spacings between paragraphs and changes link color #3

Closed zamith closed 8 years ago

zamith commented 8 years ago

Why:

This change addresses the need by:

For the links I ended up using the color already being used for the link in the banner, here's how it was in terms of contrast:

old-links-diesel

And how it is with the change:

new-links-diesel

The red means it does not pass any level of the WCAG 2.0 on contrast ratio, the green means it passes the AA level for any size and the AAA level for sizes larger than 18pt.

Spacings

For the spacings I made all of the most relevant bottom margin use base-spacing instead of ems. I tested in different screen sizes and it seems to be fine. Having more space let's the content breathe a bit more and improves readability. For the code blocks, I believe it was actually a mistake that they had no margin bottom. Here's how it was:

old-spacings-diesel

And how it is with the changes:

new-spacings-diesel
sgrif commented 8 years ago

/cc @corwinharrell I pulled in some of these today as a stopgap measure, I know you're taking a look at that page tomorrow.

sgrif commented 8 years ago

Looks like changes similar to these were made in https://github.com/sgrif/diesel.rs-website/commit/866eb10e4556dfbb951800171c873fa424bcc116. Thanks, though!