search

sgrif / diesel.rs-website

MIT License
35 stars 98 forks source link

Transfer repo to diesel-rs #58

Open moore3071 opened 6 years ago

moore3071 commented 6 years ago

It would be nice to have this repo in the diesel-rs organization next to the rest of the diesel repositories. Currently it takes a little bit of searching to find out where the diesel.rs website repo actually is.

Eijebong commented 6 years ago

IIRC we had troubles with that because of how github pages work with custom domains (we also have the documentation on that domain). I could be wrong though

moore3071 commented 6 years ago

Ah, I figured it might've been tried before. I know I've had trouble with https, gh-pages, and custom domains before, but that's clearly not the problem here. Is there any possibility that you have a link to any discussion about the attempted transfer so I could get a bit more info?

If it's not possible, could a link to this repo at least be added to the organization's description or somehow make it easier to find?

Eijebong commented 6 years ago

@sgrif ^

sgrif commented 6 years ago

The conversation would have been in our private gitter room when the diesel-rs org was created, so there's nothing I can link to that you would be able to see. I'm not sure I could find it if I wanted to since Gitter's search is terrible, and I usually use google when I need to find old conversations -- which won't work on a private room...

I'm vague on the specifics of what the issue was, but basically I'm not sure we can have multiple custom domains for different github pages sites on the same org. Here's the DNS records in question:

screen shot 2018-03-26 at 3 21 36 pm

So you can see why that would give me pause. I'm also not hot on the idea of the site basically being down for an hour while DNS propagates, but I guess I could change the records at some hour where we're unlikely to get traffic. The main reason I haven't looked more into this is that the website represents a recurring cost that I personally pay for out of pocket, so it felt right to keep it here.

All that said, I'm not opposed to transferring it over if we're 100% sure it won't break things. I think I couldn't answer that question at the time, so we didn't risk trying. Either way I 100% agree that we should have more visibility into where this repo lives. At least a link on the website itself.

moore3071 commented 6 years ago

I could see why that would give you pause. In case you do want to try that transfer, I made a post on the Github community forum relating to what you mentioned.

Otherwise it would be nice to have a link to this repo both on the website and the Github organization's description.

One more comment, half in jest and half serious, have you considered seeing if the Rust-lang maintainers would pick up the domain cost? Diesel is pretty integral to crates.io, cargo, and ergo Rust itself.