search

sgrif / diesel.rs-website

MIT License
32 stars 97 forks source link

Adding a note about barrel into docs #60

Closed spacekookie closed 6 years ago

spacekookie commented 6 years ago

Hey there,

I thought this would probably be the best place to mention that barrel exists. I'm not 100% sure on the phrasing, especially

Note that diesel doesn't officially support this.

This sounds kinda ambiguous. Or what do you think?

Also, if you're rather barrel be mentioned somewhere else, let me know. Cheers!

sgrif commented 6 years ago

I'd prefer not to document this here. It may be worth having a README for Diesel CLI specifically that mentions this in "here's a list of optional plugins we support", but I'd prefer not to go farther than that. If this were Ruby, Python, or JavaScript, barrel/diesel integration would be something that could exist with absolutely nothing happening on the Diesel side. I'm fine with having the minimal amount of code required to support this integration since there's literally no other way to do it, but I think that barrel should be promoted on its own for now, not through Diesel.

spacekookie commented 6 years ago

Right...okay.

You did mention at some point that you'd be okay/ happy with mentioning barrel somewhere in the diesel docs. Looking at the structure that exists for diesel, I thought a note in the setup guide along the lines of "Hey, new users: stop asking on gitter if diesel supports migrations in things other than SQL. Go here and shut up" would be quite welcome. But I understand.

I'd ask you to merge https://github.com/diesel-rs/diesel/pull/1573 then. it's as ready as it's ever gonna be and it only fails to build because of the whole clippy/cargo-metadata issue. I was holding out pinging you because I thought getting docs ready first was a good idea.