search

sgroschupf / zkclient

a zookeeper client, that makes life a little easier.
www.datameer.com
Apache License 2.0
1.08k stars 491 forks source link

Remove slf4j-log4j12.jar from classpath #56

Closed benmccann closed 7 years ago

benmccann commented 8 years ago

It causes conflicts in many situations. E.g. log4j-over-slf4j.jar and slf4j-log4j12.jar cannot be present simultaneously. See http://www.slf4j.org/legacy.html for more details

benmccann commented 8 years ago

I've found a few other PRs and issues open where folks want this change. This is a bit cleaner implementation for a few reasons. The other PRs are doing multiple things at once like adding to the .gitignore, reorganizing imports, adding different logging implementations, changing build file setup, etc. Most of this change is included in the other PRs. This does the minimal amount necessary to fix the issue without any of the other changes. The other PRs can be split up into multiple to address the other issues independently if desired after this PR is merged.

benmccann commented 8 years ago

@jzillmann would you be able to merge this PR? All four outstanding PRs to this repo all attempt to address this issue, which demonstrates how much trouble it's causing people. Also, if you look at this PR it has lots of upvotes demonstrating that others have reviewed and approve of this fix. I'm happy to explain in further detail if anything at all is unclear about what I'm changing or why it's necessary.

benmccann commented 8 years ago

pint @jzillmann really hoping you could take a look at this. thanks!

benmccann commented 7 years ago

@jzillmann @pvoss @fpj @sgroschupf could you guys merge this?

jzillmann commented 7 years ago

Hey @benmccann sorry, i missed your pings... will look into this tomorrow! Thanks for your patience!

jzillmann commented 7 years ago

Hey @benmccann , change looks very nice, thanks! Can double-check if everything works as expected ? If so i would release it as 0.10 version.

benmccann commented 7 years ago

Thanks. Yes, no issues on my side. I would really love a 0.10 release!

jzillmann commented 7 years ago

Ok, i triggered the release.. might take a few hours until it is available!

benmccann commented 7 years ago

Thank you!