search

sgruhier / foundation_rails_helper

Rails Helper for Zurb Fondation framework
MIT License
153 stars 84 forks source link

(chore): upgrade capybara #139

Closed dgmstuart closed 8 years ago

dgmstuart commented 8 years ago

Capybara 2.7 introduces behaviour whereby hidden elements are not recognised (this is sensible since users do not normally interact with hidden elements).

This caused a problem for a couple of our specs which asserted the presence of hidden elements.

https://github.com/sgruhier/foundation_rails_helper/pull/133 locked capybara to 2.6 because of failing specs. This PR fixes the failing specs and updates to ~>2.7

dsandstrom commented 8 years ago

Good find, I couldn't figure out why this test was failing with the latest capybara.

dgmstuart commented 8 years ago

@dsandstrom thanks!

I don't understand the spec failure, but it feels familiar. Do we need to restrict the version of Rack? That would be annoying 😒

dsandstrom commented 8 years ago

Do we need to restrict the version of Rack?

Looks like it. However, rack still doesn't install in the Ruby 2.2.0 version, but it does in #138 which uses Ruby 2.2.5.

dgmstuart commented 8 years ago

Hmm - I'm not sure it's comparable though, since the capybara upgrade doesn't happen on that branch. Are you sure it's the same version of Rack trying to be installed in both places?

dgmstuart commented 8 years ago

But we can try it out - if you're happy to merge #138

dsandstrom commented 8 years ago

Do you mind merging or rebasing the new master into this branch?

dgmstuart commented 8 years ago

Rebased