search

sgruhier / foundation_rails_helper

Rails Helper for Zurb Fondation framework
MIT License
153 stars 84 forks source link

Prevent Travis building twice on PRs #140

Closed dgmstuart closed 8 years ago

dgmstuart commented 8 years ago

Currently we have both 'build pushes' (build all pushed commits) and 'build PRs' enabled.

This means that for each commit pushed to a PR, the whole thing is built twice, identically in Travis.

This commit restricts push commits to just those made directly to the master branch.

Source: https://stackoverflow.com/questions/31882306/how-to-configure-travis-ci-to-build-pull-requests-merges-to-master-w-o-redunda

dgmstuart commented 8 years ago

Well that doesn't seem to have worked :(

dgmstuart commented 8 years ago

Hmmm - has this stopped it building on PRs altogether?

dsandstrom commented 8 years ago

I think it's working. #139 has two builds this morning, while this one has one.

dgmstuart commented 8 years ago

Ah OK - when I looked at this last it wasn't showing that /pr check.

Seems like it works then :)