search

sgruhier / foundation_rails_helper

Rails Helper for Zurb Fondation framework
MIT License
153 stars 84 forks source link

Make error_for method in form_builder public #157

Closed jeffse closed 7 years ago

jeffse commented 8 years ago

Is there a compelling reason to keep the errors_for method in FormBuilder private? I can see a use for this in my own code, where I want to be able to display the error on a property that isn't directly on my form. It's already coded here with the styling appropriate for Foundation, so I'd hate to have to duplicate the code in my own project just to use it.

Way back when, Rails v2 had a method named error_messages_for that would display these errors, but it was removed because it hardcoded certain html and styling. That shoudn't be a problem here, because we want to hardcode the Foundation styling.

dsandstrom commented 8 years ago

I don't see any reason why it has to stay private.