search

sgruhier / foundation_rails_helper

Rails Helper for Zurb Fondation framework
MIT License
153 stars 84 forks source link

Making the error_for method public #158

Closed jeffse closed 8 years ago

jeffse commented 8 years ago

157 Making the error_for method in form_builder public.

Moving the return statement up at the beginning of the method. No sense in calculating the class_name if there are no errors for the attribute.

dsandstrom commented 8 years ago

@jeffse In the future, create a feature branch before making changes for a PR.

$ git checkout -b my-new-feature

So you can fetch/merge from upstream if you need to rebase or create more PRs.

Rubocop is failing: "use normalcase for variable numbers" https://github.com/bbatsov/rubocop/blob/af0bc67e6e5a75f8a850c5fbf640d0f08bc3078d/lib/rubocop/cop/style/variable_number.rb

It's unrelated to this PR so we'll have to fix this in master.

jeffse commented 8 years ago

Thanks for the tip. Usually for small commits I haven't bothered creating a branch, but I can do so for future commits.