Fix label output in checkbox when labels have HTML

sgruhier / foundation_rails_helper

Rails Helper for Zurb Fondation framework

MIT License

153 stars 83 forks source link

Fix label output in checkbox when labels have HTML #159

Closed oriolgual closed 7 years ago

oriolgual commented 7 years ago

This PR fixes the case when you have a checkbox with a label that has HTML content (like an accept terms and conditions checkbox with a link to the terms), right now the label is not properly escaped and the link isn't marked as safe.

It also fixes some rubocop offenses so the build is green.

oriolgual commented 7 years ago

Updated!

oriolgual commented 7 years ago

I don't know why but rubocop is complaining about foundation_rails_helper.gemspec having too many lines :/

dsandstrom commented 7 years ago

Thanks @oriolgual.