search

sgruhier / foundation_rails_helper

Rails Helper for Zurb Fondation framework
MIT License
153 stars 84 forks source link

Fix rubocop errors #160

Closed dsandstrom closed 7 years ago

dsandstrom commented 8 years ago

@dgmstuart When you get a chance, can you review this PR?

I went through all the files and fixed most linting errors raised by Rubocop. I'll squash these commits after you're satisfied.

dsandstrom commented 8 years ago

Thanks for the review and sorry for the lack of documentation. I need to get better at that.

I agree on the line length. However, I wasn't trying to do a lot of refactoring, just get Rubocop to pass. Yet, there needs to be refactoring done. When I was half way done with fixing the spec files, I thought that I should have just increased the maximum line length instead of adjusting things. However, it's probably good in the end because new tests will be stricter and more concise.

I will fix the issues you brought up, squash commits, and write longer commit messages.

dsandstrom commented 7 years ago

Replaced by #162