sgruhier / foundation_rails_helper

Rails Helper for Zurb Fondation framework
MIT License
153 stars 84 forks source link

Rails 6 support #177

Closed werebus closed 5 years ago

werebus commented 5 years ago

I expanded the constraint in the gemspec to include Rails 6. There were a few changes to the spec setup that were needed in order for them to run on Rails 6, those changes were backward compatible with Rails 4 and 5.

I also expanded the Travis setup:

I think one could be less generous on supported versions -- Rails 4.2 should be EOL now that Rails 6 is out, and ruby 2.2 has been EOL for a little over a year -- but I didn't want to presume.

I think the only thing left is to determine the version number and update the CHANGELOG. I didn't technically remove Rails 4.1 support, but I did remove it from Travis.

mijailr commented 5 years ago

Any update to this?